[PATCH] D70779: AArch64: add support for newer Apple CPUs

Ahmed Bougacha via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 2 12:25:14 PST 2019


ab added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:587
+                                    "Apple A10", [
+                                    ProcAppleA7,
+                                    FeatureCRC,
----------------
I'm not sure we want to reuse the features:
- everything will get stuck with FeatureZCZeroingFPWorkaround, right? (but maybe we can remove features in this list?  I don't think so)
- it probably becomes harder to tune later chips, but that's admittedly a theoretical problem at this point
- some of the features can be generation-specific


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70779/new/

https://reviews.llvm.org/D70779





More information about the cfe-commits mailing list