[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

@sammccall Sam, it looks like the tests are failing on the darwin bots:

http://lab.llvm.org:8080/green/job/clang-stage1-RA/4243/consoleFull

  Value of: CDB.getFallbackCommand(testPath("bar.cc")).CommandLine
  Expected: has 6 elements where
  element #0 ends with "clang",
  element #1 is equal to "-DA=2",
  element #2 is equal to "/clangd-test/bar.cc",
  element #3 is equal to "-DA=4",
  element #4 is equal to "-fsyntax-only",
  element #5 starts with "-resource-dir"
    Actual: { "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang", "-DA=2", "/clangd-test/bar.cc", "-DA=4", "-fsyntax-only", "-resource-dir=/Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/tools/clang/tools/extra/clangd/lib/clang/10.0.0", "-isysroot", "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk" }, which has 8 elements

Can you please take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70863/new/

https://reviews.llvm.org/D70863