[PATCH] D69740: [profile] Support counter relocation at runtime

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 2 08:52:54 PST 2019


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Lgtm with a small cleanup.



================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:674
+  if (isRuntimeCounterRelocationEnabled()) {
+    Type *Int64Ty = Type::getInt64Ty(M->getContext());
+    Type *Int64PtrTy = Type::getInt64PtrTy(M->getContext());
----------------
Could you lazily insert the bias load inside of `lowerIncrement`? That removes the need to delete the load when no increment is found.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69740/new/

https://reviews.llvm.org/D69740





More information about the cfe-commits mailing list