[PATCH] D70183: Detect source location overflow due includes

[Mikhail Maltsev via Phabricator via cfe-commits]

miyuki added a comment.

> clang shall either die due an assert in debug [...]

I think I have already mentioned the reasons why I don't think this is acceptable:

- it would break tests, as they are usually run with enabled assertions (and since this diagnostic is quite easy to test, it should be tested)
- it would make the code harder to debug (i.e. if someone finds another problem related to large includes, they would first need to fix the failing assertions before they could start debugging their problem)

IMHO we should discuss this in person, that would be quicker.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70183/new/

https://reviews.llvm.org/D70183