[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

[Sam McCall via Phabricator via cfe-commits]

sammccall updated this revision to Diff 231674.
sammccall added a comment.
This revision is now accepted and ready to land.

Also add detected -isysroot on mac unless $SDKROOT is set.
Also add path to driver when bare driver name comes from CDB.
While here, address -resource-dir fixme.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70863/new/

https://reviews.llvm.org/D70863

Files:
  clang-tools-extra/clangd/GlobalCompilationDatabase.cpp
  clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp
  clang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70863.231674.patch
Type: text/x-patch
Size: 9216 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191202/5ed8097a/attachment-0001.bin>