[PATCH] D70489: [clangd] Add xref for macro to static index.

[UTKARSH SAXENA via Phabricator via cfe-commits]

usaxena95 marked 2 inline comments as done.
usaxena95 added inline comments.


================
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:374
+        Roles & static_cast<unsigned>(index::SymbolRole::Definition) ||
+        Roles & static_cast<unsigned>(index::SymbolRole::Reference)))
     return true;
----------------
usaxena95 wrote:
> hokein wrote:
> > I think we should avoid running the code below if this is a mere reference.
> Interesting. Just to understand it better can you give an example where the Role is just a reference ?
My bad. Got this one. The part below it is just for the symbol slab so it's fine to omit a reference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70489/new/

https://reviews.llvm.org/D70489