[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 2 00:24:34 PST 2019


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM



================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:275
+      if (NNS->getKind() == NestedNameSpecifier::Identifier) {
+        H.addToken(Q.getLocalBeginLoc(), HighlightingKind::DependentType);
+      }
----------------
NIT: remove braces from the inner `if`. They look totally ok in the outer if, though


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70746/new/

https://reviews.llvm.org/D70746





More information about the cfe-commits mailing list