[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Dec 1 08:54:13 PST 2019
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a minor commenting request.
================
Comment at: clang/include/clang/AST/Decl.h:2400
+ /// Attempt to compute an informative source range covering the
+ /// function parameters, excluding the parentheses. The source range is
+ /// invalid if there are no parameters.
----------------
You should make the comment clear that this will include the ellipsis (which is sort of a parameter, sort of not).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63276/new/
https://reviews.llvm.org/D63276
More information about the cfe-commits
mailing list