[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 30 11:49:37 PST 2019


Mordante added a comment.

I like this improvement. However I'm not a reviewer.



================
Comment at: clang/lib/Sema/SemaChecking.cpp:12361
+  /// \param RefsSeenPtr is used to avoid reference cycles. When such a cycle
+  /// is possible we check first if \param RefsSeenPtr is non-null. If it is
+  /// non-null we use the pointed SmallPtrSet and if null we create one on the
----------------
Please use \p here since it's not a parameter definition.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57660/new/

https://reviews.llvm.org/D57660





More information about the cfe-commits mailing list