[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

[Mariya Podchishchaeva via Phabricator via cfe-commits]

Fznamznon added a comment.

A couple of minor comments.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:313
+
+- Function template with at least two template parameters is expected. The compiler
+generates OpenCL kernel and uses first template parameter as unique name to the
----------------
aaron.ballman wrote:
> The function must be a template with at least two type template parameters.
@bader , could you please apply this too?


================
Comment at: clang/include/clang/Basic/AttrDocs.td:314
+  expected. The compiler generates an OpenCL kernel and uses the first template
+  parameter as a unique name to the generated OpenCL kernel. The host
+  application uses this unique name to invoke the OpenCL kernel generated for
----------------
I'm not an expert in English, so you can ignore it if I'm wrong, but a phrase like "uses parameter as a name **to **the kernel" seems strange. Maybe "**for ** kernel"?


================
Comment at: clang/include/clang/Basic/AttrDocs.td:317
+  the ``sycl_kernel_function`` specialized by this name and second template
+  parameter ``KernelType`` (which might be a lambda type).
+- The function must have at least one parameter. The first parameter is
----------------
(which might be a lambda or a function object type).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60455/new/

https://reviews.llvm.org/D60455