[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

Sat Nov 30 00:49:13 PST 2019

johannes added a comment.

In D70302#1763025 <https://reviews.llvm.org/D70302#1763025>, @rnk wrote:

> Fix looks good post commit, but we should enhance the test.

I see, apologies for the premature commit.

================
Comment at: clang/test/CodeGen/label-array-aggregate-init.c:1
+// RUN: %clang -cc1 -emit-llvm %s -o /dev/null
+
----------------
rnk wrote:
> It's best practice to filecheck for something, even if this used to crash.
I guess the test should make sure that the array is constructed successfully after codegen.
I'm unsure about the best way to test that. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70302/new/

https://reviews.llvm.org/D70302