[PATCH] D69620: Add AIX assembler support

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 29 09:42:17 PST 2019


hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68
+  if (Inputs.size() != 1)
+    llvm_unreachable("Invalid number of input files.");
+  const InputInfo &II = Inputs[0];
----------------
`llvm_unreachable` is not the right solution if this can be reached by "user error". We should produce a proper error message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69620/new/

https://reviews.llvm.org/D69620





More information about the cfe-commits mailing list