[PATCH] D70857: [llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 29 07:02:04 PST 2019


kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
kadircet added a parent revision: D70769: [Support] add vfs support for ExpandResponseFiles.
kadircet edited parent revisions, added: D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json; removed: D70769: [Support] add vfs support for ExpandResponseFiles.

This is a follow-up to D70769 <https://reviews.llvm.org/D70769> and D70222 <https://reviews.llvm.org/D70222>, which allows propagation of
current directory down to ExpandResponseFiles for handling of relative paths.

Previously clients had to mutate FS to achieve that, which is not thread-safe
and can even be thread-hostile in the case of real file system.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70857

Files:
  clang/include/clang/Tooling/CompilationDatabase.h
  clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp
  clang/lib/Tooling/JSONCompilationDatabase.cpp
  llvm/include/llvm/Support/CommandLine.h
  llvm/lib/Support/CommandLine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70857.231536.patch
Type: text/x-patch
Size: 9207 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191129/9b0c09a4/attachment.bin>


More information about the cfe-commits mailing list