[PATCH] D70183: Detect source location overflow due includes

Diogo N. Sampaio via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 29 06:50:01 PST 2019


dnsampaio added a comment.

Just wondering, I don't fully understand why is that important from the point I do a `return FileID();`. The critical error has already been inserted to the error list. clang shall either die due an assert in debug, or with a nice message in release. Unless clang is all broken, and the error message would be corrupted, which I don't believe is the case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70183/new/

https://reviews.llvm.org/D70183





More information about the cfe-commits mailing list