[PATCH] D70853: [clangd] Fix a regression issue in local rename.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 29 06:38:15 PST 2019
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:136
+ else if (!DeclaredInMainFile)
+ // the symbol declared outside of the main file, can't be main file only.
+ IsMainFileOnly = false;
----------------
NIT: the comment seems to duplicate the code, maybe remove it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70853/new/
https://reviews.llvm.org/D70853
More information about the cfe-commits
mailing list