[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

[James Henderson via Phabricator via cfe-commits]

jhenderson added a comment.

In D70769#1763703 <https://reviews.llvm.org/D70769#1763703>, @kadircet wrote:

> @jhenderson I am planning to commit this if the discussion around `std::errc` vs `llvm::errc` is resolved, I don't have any preference towards one or the other both seems to get the work done.


I'm not going to block this being committed. I do think llvm::errc exists for a reason, and those reasons are documented in the associated file, giving me the impression we should use it and not std::errc. However, I don't know how applicable those reasons really are nowadays - I'm certainly no authority on them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70769/new/

https://reviews.llvm.org/D70769