[PATCH] D70832: [clangd] Log cc1 args at verbose level.

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev added a comment.

Sorry, seems I was too late :(



================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:412
     std::unique_ptr<CompilerInvocation> Invocation =
         buildCompilerInvocation(Inputs, CompilerInvocationDiagConsumer);
+    // Log cc1 args even (especially!) if creating invocation failed.
----------------
`buildCompilerInvocation(Inputs, CompilerInvocationDiagConsumer, &CC1Args)`? Otherwise, I think the vector would always be empty, right?


================
Comment at: clang/include/clang/Frontend/Utils.h:231
+    bool ShouldRecoverOnErrors = false,
+    std::vector<std::string> *CC1Args = nullptr);
 
----------------
Nit: `llvm::Optional` might look better for `CC1Args`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70832/new/

https://reviews.llvm.org/D70832