[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

[Valentin Churavy via Phabricator via cfe-commits]

vchuravy marked an inline comment as done.
vchuravy added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:113
+                        TT.isArch64Bit() ? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1"
+                                         : "e-m:e-p:32:32-i64:64-n32:64-S128-ni:1",
                         TT, CPU, FS, Options, getEffectiveRelocModel(RM, TT),
----------------
vchuravy wrote:
> aheejin wrote:
> > Is this gonna support existing .ll files with the previous data layout?
> I don't see why it shouldn't without activating `-mattr=+reference-types` new .ll files won't compile,
> but old one should.
I see what you meant know after building emscripten/binaryen with these changes, I made the DL changes depending on the feature flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66035/new/

https://reviews.llvm.org/D66035