[clang-tools-extra] 08cce03 - [clangd] Tweak the no-index error message for rename, NFC.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 28 04:03:47 PST 2019


Author: Haojian Wu
Date: 2019-11-28T13:03:28+01:00
New Revision: 08cce03a6d959c899e07398603c85168a96f549c

URL: https://github.com/llvm/llvm-project/commit/08cce03a6d959c899e07398603c85168a96f549c
DIFF: https://github.com/llvm/llvm-project/commit/08cce03a6d959c899e07398603c85168a96f549c.diff

LOG: [clangd] Tweak the no-index error message for rename, NFC.

Summary: The current error message doesn't fit well for cross-file rename.

Reviewers: ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D70809

Added: 
    

Modified: 
    clang-tools-extra/clangd/refactor/Rename.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/refactor/Rename.cpp b/clang-tools-extra/clangd/refactor/Rename.cpp
index ab121d434c9c..f775539cb63d 100644
--- a/clang-tools-extra/clangd/refactor/Rename.cpp
+++ b/clang-tools-extra/clangd/refactor/Rename.cpp
@@ -186,7 +186,7 @@ llvm::Error makeError(ReasonToReject Reason) {
     case ReasonToReject::NoSymbolFound:
       return "there is no symbol at the given location";
     case ReasonToReject::NoIndexProvided:
-      return "symbol may be used in other files (no index available)";
+      return "no index provided";
     case ReasonToReject::UsedOutsideFile:
       return "the symbol is used outside main file";
     case ReasonToReject::NonIndexable:


        


More information about the cfe-commits mailing list