[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/Hover.cpp:363
   HI.Name = Macro.Name;
-  HI.Kind = indexSymbolKindToSymbolKind(
-      index::getSymbolInfoForMacro(*Macro.Info).Kind);
+  HI.Kind = index::getSymbolInfoForMacro(*Macro.Info).Kind;
   // FIXME: Populate documentation
----------------
just Kind = Macro seems clearer...


================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:473
          HI.Definition = "static constexpr int result = a + b";
-         HI.Kind = SymbolKind::Property;
+         HI.Kind = index::SymbolKind::StaticProperty;
          HI.Type = "const int";
----------------
(FWIW, both the old and the new value here seem suspect - this isn't a property)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70723/new/

https://reviews.llvm.org/D70723