[PATCH] D70809: [clangd] Tweak the no-index error message for rename, NFC.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 28 02:43:09 PST 2019
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
The current error message doesn't fit well for cross-file rename.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D70809
Files:
clang-tools-extra/clangd/refactor/Rename.cpp
Index: clang-tools-extra/clangd/refactor/Rename.cpp
===================================================================
--- clang-tools-extra/clangd/refactor/Rename.cpp
+++ clang-tools-extra/clangd/refactor/Rename.cpp
@@ -186,7 +186,7 @@
case ReasonToReject::NoSymbolFound:
return "there is no symbol at the given location";
case ReasonToReject::NoIndexProvided:
- return "symbol may be used in other files (no index available)";
+ return "no index provided";
case ReasonToReject::UsedOutsideFile:
return "the symbol is used outside main file";
case ReasonToReject::NonIndexable:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70809.231389.patch
Type: text/x-patch
Size: 624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191128/eb543aa9/attachment-0001.bin>
More information about the cfe-commits
mailing list