[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

[James Henderson via Phabricator via cfe-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/Support/CommandLine.cpp:1071
+      return llvm::make_error<llvm::StringError>(
+          "Could not convert UTF16 To UTF8", llvm::inconvertibleErrorCode());
     Str = StringRef(UTF8Buf);
----------------
Not sure, but you might want to use `illegal_byte_sequence` here instead of `llvm::inconvertibleErrorCode()`.


================
Comment at: llvm/lib/Support/CommandLine.cpp:1178
+
+    if (llvm::Error Err = ExpandResponseFile(FName, Saver, Tokenizer, ExpandedArgv, MarkEOLs,
+                            RelativeNames, FS)) {
----------------
clang-format please


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70769/new/

https://reviews.llvm.org/D70769