[PATCH] D70779: AArch64: add support for newer Apple CPUs

Tim Northover via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 28 01:31:04 PST 2019


t.p.northover marked an inline comment as done.
t.p.northover added a comment.

Thanks Florian. I'll wait as you suggest.



================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:143
     MtuneLowerCase = llvm::sys::getHostCPUName();
-  if (MtuneLowerCase == "cyclone") {
+  if (MtuneLowerCase == "cyclone" || MtuneLowerCase.find("apple") == 0) {
     Features.push_back("+zcm");
----------------
fhahn wrote:
> It might be slightly more obvious to use MtuneLowerCAse.StartsWith("apple")
I'd have preferred to, but unfortnately it's a `std::string` so doesn't have that function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70779/new/

https://reviews.llvm.org/D70779





More information about the cfe-commits mailing list