[PATCH] D60455: [SYCL] Implement SYCL device code outlining

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

The attribute bits LGTM aside from a wording nit with the diagnostic; I have no opinion on the CodeGen question.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10080
+  "template parameter of a function template with the 'sycl_kernel' attribute"
+  " can't be a non-type template parameter">, InGroup<IgnoredAttributes>;
+def warn_sycl_kernel_num_of_function_params : Warning<
----------------
`can't` -> `cannot`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60455/new/

https://reviews.llvm.org/D60455