[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D70791#1762155 <https://reviews.llvm.org/D70791#1762155>, @rnk wrote:

> My version of cl.exe claims to have version 19.23.28107 and my headers are in Tools/MSVC/14.23.28105/include, and I see that this is fixed in xtr1common. is_integral_v and the helpers are defined with implicit template instantiations. There are no fully specialized template definitions in that header. So, my hope is that this problem will go away as users run the VS updater. Although, for buildbots and users such as myself who rarely start the IDE, that may take longer than we'd like.


Ah, I see!  I have no idea what that version is unfortunately... 14.23 is just 16.3 I think, but no idea which of the _10_ sub releases that is (https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes).  My tester claims to have a completely up to date version, but I'll have them check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70791/new/

https://reviews.llvm.org/D70791