[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 27 11:23:27 PST 2019


alexfh added a comment.

In D69746#1756448 <https://reviews.llvm.org/D69746#1756448>, @gribozavr2 wrote:

> The only way I know people apply fixits is with the help of IDEs.


This depends on the infrastructure available. Talking specifically about clang-tidy in our environment, I know of at least three other modes that are being frequently used:

- in a code review tool (allows to apply manually selected fixes one-by-one);
- in a code browsing tool (allows to apply manually selected fixes or all fixes of a certain category - e.g. from performance-related checks - to a file or directory);
- a script that applies pre-generated fixes to a set of files or all repository.

> I am also skeptical that people want to apply *all* fixits. Usually people want to pick a few specific ones, or all fixits of a certain kind; but not everything.

While "all fixits" may be not particularly useful, "apply all fixes enabled for my project" is a reasonable function when the project is generally kept in a clean shape.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69746/new/

https://reviews.llvm.org/D69746





More information about the cfe-commits mailing list