[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 27 11:05:15 PST 2019


rjmccall added inline comments.


================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:4108
+      NewToType = Context.getPointerType(NewToType);
+    }
+
----------------
Hmm, sorry, just noticed this.  Could you write this so that it preserves the original kind of pointer of `ToType`?  I think it has to be a `PointerType`, `BlockPointerType,` or `ObjCObjectPointerType`.  It doesn't look like there's an existing utility for that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70605/new/

https://reviews.llvm.org/D70605





More information about the cfe-commits mailing list