[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 27 10:45:53 PST 2019


rnk added a subscriber: thakis.
rnk added a comment.

I thought we agreed to remove the workaround that we had for this and just declare that the old MSVC STL release was buggy and users should update:
https://bugs.llvm.org/show_bug.cgi?id=42027
It's a point release that preserves ABI compatibility, so there's less motivation for us to add a compat hack.

In general, we should seriously think about sunsetting some MS compat hacks that aren't needed for new SDK/STL versions to save on clang maintenance costs. The complexity they add is surprisingly expensive. For example, -fdelayed-template-parsing is a recurring source of compat issues in clang-tools-extra (see the commit logs), and I would like to revive D66394 <https://reviews.llvm.org/D66394> to get it disabled by default soon. (+ at thakis)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70791/new/

https://reviews.llvm.org/D70791





More information about the cfe-commits mailing list