[PATCH] D70693: [scan-build-py] Set of small fixes

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun marked an inline comment as done.
xazax.hun added inline comments.


================
Comment at: clang/tools/scan-build-py/libscanbuild/clang.py:47
     cmd.insert(1, '-###')
+    cmd.append('-fno-color-diagnostics')
 
----------------
phosek wrote:
> Alternative would be to set `TERM=dumb` environment variable which disables color support as well, but this also works.
Thanks! I'd love to have another solution, but it looks like the command line takes precedence over the environment variables and if `-fcolor-diagnostics` is specified in the command line it will always turn the colors on. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70693/new/

https://reviews.llvm.org/D70693