[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles
James Henderson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 27 05:59:07 PST 2019
jhenderson added a comment.
Aside from one nit, this looks okay to me. I'd like someone else to look at it though too. I'm not at all familiar with the file system stuff to be confident to say everything there is good.
================
Comment at: llvm/lib/Support/CommandLine.cpp:1148
+ SmallVector<char, 128> RHSPath;
+ if (FS.getRealPath(FName, LHSPath) || FS.getRealPath(RFile.File, RHSPath)) {
+ return false;
----------------
Has this been clang-formatted?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70769/new/
https://reviews.llvm.org/D70769
More information about the cfe-commits
mailing list