[PATCH] D70764: build: reduce CMake handling for zlib

Pavel Labath via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 26 23:47:13 PST 2019


labath added a comment.

Please take a look at D70519 <https://reviews.llvm.org/D70519> for the issues with this approach.

Also, while I do agree with you that we should not auto-select dependencies, I think this runs contrary to the llvm philosophy that the default built should "just work" (I don't know if that's formalized anywhere, but I know it's certainly what (some?) people expect).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70764/new/

https://reviews.llvm.org/D70764





More information about the cfe-commits mailing list