hliao accepted this revision. hliao added a comment. This revision is now accepted and ready to land. LGTM, anyway calling a virtual function inside the constructor is not encouraged. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70729/new/ https://reviews.llvm.org/D70729