[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

[Scott Linder via Phabricator via cfe-commits]

scott.linder added a comment.

In D70424#1759379 <https://reviews.llvm.org/D70424#1759379>, @t-tye wrote:

> @scott.linder can answer about the -g question, but I would expect that the CFI is capable of describing the address of the CFA regardless of whether there is a frame pointer by simply knowing the constant offset from the stack pointer.
>
> For AMDGPU it seems to me what we really have is an FP and we optimize away the SP since the stack grows low address to high address, and S32 points to the base of the frame, and not the top of the stack.


Right, with CFI we will be able to describe every case we can generate code for, regardless of whether we optimize out the FP.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70424/new/

https://reviews.llvm.org/D70424