[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 25 08:24:37 PST 2019

Previous message: [PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.
Next message: [PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

yaxunl added a comment.

LGTM. But I am wondering how it affects -g. Do we need to keep frame pointer when -g is specified? Should we add a test for -O3 -g?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70424/new/

https://reviews.llvm.org/D70424

Previous message: [PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.
Next message: [PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list