[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

Mon Nov 25 05:08:52 PST 2019

ilya-biryukov added a comment.

In D70440#1756262 <https://reviews.llvm.org/D70440#1756262>, @thakis wrote:

> Do we need to add a dep on Frontend to DriverTests here? That's a heavy dependency (it pulls in Sema etc). If it is needed, maybe the test is in the wrong binary?

We need it solely for `TextDiagnosticPrinter`. Very handy to see the errors in case of failures.
There are probably no reasons it cannot live outside frontend, should be a manageable refactoring. (I haven't checked though, might be wrong)

Logically, the tests seem to be in the right place.

I agree it's not perfect, but there are probably more useful things one can spend their time on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70440/new/

https://reviews.llvm.org/D70440