[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 25 01:18:43 PST 2019


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:961
 
 TEST(IgnoreDiags, FromNonWrittenInclude) {
   TestTU TU = TestTU::withCode("");
----------------
I'd move this to the end of the file, so that all `DiagsInHeaders` are grouped together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70494/new/

https://reviews.llvm.org/D70494





More information about the cfe-commits mailing list