[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

[Nico Weber via Phabricator via cfe-commits]

thakis added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:137
+      getFilePaths().push_back(getDriver().SysRoot + "/lib/" + MultiarchTriple +
+                               "/llvm-lto");
+    }
----------------
sunfish wrote:
> sbc100 wrote:
> > Is there any kind of president here?   i.e. do any other platforms have support for this kind thing?  Seems like good idea I'd just like to be sure we follow existing practices.
> I looked around, but didn't see anything similar.
One immediate problem of this approach is that if HAVE_VCS_VERSION_INC is not set, then the test fails, but if it is set, `clang --version` reports a current git hash, which is either out of date or requires a pretty big rebuild on every single git commit (i.e. not just after `git pull` but also after local commits). Neither's great.

Do you expected that sysroots will ship 3-4 LTO folders, to support ~2 years of clang releases? Or do you expect that a sysroot will always support a single clang/llvm revision? If so, maybe the LLVM version is enough?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70500/new/

https://reviews.llvm.org/D70500