[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 23 04:37:28 PST 2019


thakis reopened this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Please don't add code to the driver that runs programs off PATH. Nothing else does this. If you need to run an external program, look for it next to the compiler, like we do for gas with -fno-integrated-as, linker, etc. People can use the existing -B flag to make clang look elsewhere if they need that.

It's also somewhat uncommon to run non-LLVM binaries, but I can see the need for doing that at least during some transition period (like we did with the assembler).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70500/new/

https://reviews.llvm.org/D70500





More information about the cfe-commits mailing list