[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

Sjoerd Meijer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 23 01:55:32 PST 2019


SjoerdMeijer added a comment.

I don't think I have full context of the problem.... but in this diff I see type `__fp16`, which is the storage-only type. But if we are talking about v8.2-A and FP16, then we are talking about the native type (e.g. source-language type `_Float16`), and for that you need to enable the `+fp16` architecture extension.  I would have to refresh my memory, but I thought `-fnative-half-type` was used to enable OpenCL fp16 types? Either way, it looks like there's interaction between `__fp16` and native FP16 types, but I don't think adding `-fnative-half-type` is the right approach. But as I said, I don't know exactly what the problem is, and would need to have a proper look when I'm back at my desk.


BRANCHES
  master

Users:
  ahatanak (Author)

https://reviews.llvm.org/rG825235c140e7





More information about the cfe-commits mailing list