[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 22 10:18:37 PST 2019


ABataev added a comment.

In D70551#1757065 <https://reviews.llvm.org/D70551#1757065>, @sdmitriev wrote:

> I would agree with you if data layout was indeed available in the driver, but unfortunately driver does not have access to any existing TargetInfo instance (or maybe I just have not found it). So, I have to create TargetInfo and build data layout even for the case when driver passes it to the wrapper tool. I guess that would also be a default data layout, so it would not differ much from what I have already done in this patch. BTW, I will probably upload an alternative patch where I have implemented your suggestion, just to compare))


Of course, this is not a good solution. I was hoping that TargetInfo is available in driver. Otherwise, it would be good somehow to read the target data from the .bc file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70551/new/

https://reviews.llvm.org/D70551





More information about the cfe-commits mailing list