[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

Clement Courbet via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 21 23:46:30 PST 2019


courbet marked an inline comment as done.
courbet added a comment.

Thanks for the review.



================
Comment at: clang-tools-extra/clang-tidy/performance/NoAutomaticMoveCheck.cpp:32
+
+  const auto const_local_variable =
+      varDecl(hasLocalStorage(), unless(hasType(lValueReferenceType())),
----------------
JonasToth wrote:
> Last nits: all variables do not follow the LLVM convention of camel-casing. Just realized now, sorry
Oh yes right, thanks for the catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70390/new/

https://reviews.llvm.org/D70390





More information about the cfe-commits mailing list