[PATCH] D67537: [clangd] Client-side support for inactive regions

[Nathan Ridge via Phabricator via cfe-commits]

nridge marked an inline comment as done.
nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:210
+      isWholeLine: true,
+      // FIXME: Avoid hardcoding these colors.
+      light: {
----------------
I'm open to suggestions for how we could avoid harcoding these colors. VSCode themes do not seem to include colors for `"meta.disabled"` or any similar scope that would fit this role.

Perhaps we can allow the user to define the colors in clangd-specifier setting names, e.g. `clangd.inactiveHighlightColor.light`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67537/new/

https://reviews.llvm.org/D67537