[PATCH] D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 21 14:39:10 PST 2019


dexonsmith marked 2 inline comments as done.
dexonsmith added inline comments.


================
Comment at: clang/include/clang/Lex/ModuleLoader.h:50
+    // We failed to load the module, but we shouldn't cache the failure.
+    OtherUncachedFailure,
   };
----------------
jkorous wrote:
> Just a typo - the comma at the end.
That comma was intentional, actually!  Then the next time a value gets added/removed it doesn't unnecessarily cause differences to other liens :).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70556/new/

https://reviews.llvm.org/D70556





More information about the cfe-commits mailing list