[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

Sergey Dmitriev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 21 14:03:10 PST 2019


sdmitriev added a comment.

In D70551#1755768 <https://reviews.llvm.org/D70551#1755768>, @ABataev wrote:

> In D70551#1755761 <https://reviews.llvm.org/D70551#1755761>, @sdmitriev wrote:
>
> > In D70551#1755583 <https://reviews.llvm.org/D70551#1755583>, @ABataev wrote:
> >
> > > In D70551#1755553 <https://reviews.llvm.org/D70551#1755553>, @sdmitriev wrote:
> > >
> > > > In D70551#1755527 <https://reviews.llvm.org/D70551#1755527>, @ABataev wrote:
> > > >
> > > > > Why do we need this?
> > > >
> > > >
> > > > To pass wrapper bitcode directly to the linker when LTO is enabled. LTO plugin does not accept bc if there is no data layout.
> > >
> > >
> > > Maybe it would better to pass it a parameter just like for opt?
> >
> >
> > In this case clang driver would need to get it from somewhere in order to pass it to the wrapper tool. I do not know where it can get it from.
>
>
> `TargetInfo` class is not accessible in the driver?


Ah, I see, you mean clang's TargetInfo. Let me check if/how it will work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70551/new/

https://reviews.llvm.org/D70551





More information about the cfe-commits mailing list