[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Kousik Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 21 12:31:21 PST 2019


kousikk added inline comments.


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:75-79
+    llvm::Optional<StringRef> Redirects[] = {
+        {""}, // Stdin
+        StringRef(OutputFile),
+        StringRef(ErrorFile),
+    };
----------------
Bigcheese wrote:
> It would be nice if this didn't need to be a real file, but it looks like `llvm::sys::Execute` can only handle file paths.
Yup - I'm going to leave it as such for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69122/new/

https://reviews.llvm.org/D69122





More information about the cfe-commits mailing list