[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

Robert Widmann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 21 09:01:43 PST 2019


CodaFi added a comment.

C binding changes LGTM.  Don’t worry about changing them, they are marked as experimental and subject to change at any time.



================
Comment at: llvm/include/llvm-c/DebugInfo.h:878
                            LLVMMetadataRef File, unsigned LineNo,
-                           LLVMMetadataRef Scope);
+                           LLVMMetadataRef Scope, uint32_t AlignInBits);
 
----------------
sammccall wrote:
> These functions in llvm-c are ABI-stable AFAIK.
> (This broke the go bindings which are in-tree, but could equally break out-of-tree bindings)
The debug info bindings are not subject to the ABI stability guarantees of the rest of the C bindings to LLVM’s core.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70111/new/

https://reviews.llvm.org/D70111





More information about the cfe-commits mailing list