[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 21 07:58:07 PST 2019


JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.

LGTM after the variable names are adjusted



================
Comment at: clang-tools-extra/clang-tidy/performance/NoAutomaticMoveCheck.cpp:32
+
+  const auto const_local_variable =
+      varDecl(hasLocalStorage(), unless(hasType(lValueReferenceType())),
----------------
Last nits: all variables do not follow the LLVM convention of camel-casing. Just realized now, sorry


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70390/new/

https://reviews.llvm.org/D70390





More information about the cfe-commits mailing list