[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 21 03:01:09 PST 2019
ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1877
- EXPECT_EQ(Results.Completions.size(), 1u);
+ ASSERT_EQ(Results.Completions.size(), 1u);
EXPECT_THAT(Results.Completions.front().CompletionTokenRange,
----------------
We should not break out of the loop here.
Maybe do
```
if (size() != 1) {
ADD_FAILURE() << "";
continue;
}
```
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70528/new/
https://reviews.llvm.org/D70528
More information about the cfe-commits
mailing list