[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

Wed Nov 20 23:35:53 PST 2019

poelmanc marked an inline comment as done.
poelmanc added a comment.

In D68682#1753357 <https://reviews.llvm.org/D68682#1753357>, @kadircet wrote:

> also could you rename the revision so that it reflects the fact that, this is a change to clang-format and has nothing to do with clang-tidy ?

Done but feel free to suggest a better title.

(This journey started out with me trying to fix what I thought was a small quirk in clang-tidy's readability-redundant-member-init. Great feedback from more experienced developers along the way steered me to `cleanupAroundReplacements`, which feels perfect, but now I realize that gives it a broader impact.)

Thank you so much for the review and feedback!

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68682/new/

https://reviews.llvm.org/D68682