[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names
Dan Gohman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 20 20:41:08 PST 2019
sunfish added a comment.
> Do you think that setting this attribute should also prevent GC?
That sounds right to me.
> I could split this up into clang, llvm, and lld parts if it makes reviewing simpler.
For me, it's easier to have it all together in one.
In this patch, `export_name` has a required string operand, which makes sense to me. I wonder if it also makes sense to change wasm-ld's `--export` command-line option to take a pair of strings, a symbol and a name to export it as.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70520/new/
https://reviews.llvm.org/D70520
More information about the cfe-commits
mailing list